From c80f3ed45782956125e5c9bb79416f1bd0fc8030 Mon Sep 17 00:00:00 2001
From: xiangyu <3170102889@zju.edu.cn>
Date: Thu, 12 Jan 2023 16:55:18 +0800
Subject: [PATCH] fix: prefs locale example

---
 src/modules/preferenceScript.ts | 24 +++++++-----------------
 1 file changed, 7 insertions(+), 17 deletions(-)

diff --git a/src/modules/preferenceScript.ts b/src/modules/preferenceScript.ts
index ce0318f..348ffb1 100644
--- a/src/modules/preferenceScript.ts
+++ b/src/modules/preferenceScript.ts
@@ -48,25 +48,15 @@ async function updatePrefsUI() {
   const renderLock = ztoolkit.getGlobal("Zotero").Promise.defer();
   const tableHelper = new ztoolkit.VirtualizedTabel(addon.data.prefs?.window!)
     .setContainerId(`${config.addonRef}-table-container`)
-    // Add locale for table columns
-    // Object.fromEntries is only available on firefox 62+,
-    .setLocale(
-      Array.from(
-        new Map(
-          addon.data.prefs?.columns.map((column) => [
-            column.label,
-            getString(column.label),
-          ])
-        )
-      ).reduce((obj, [key, value]) => {
-        obj[key] = value;
-        return obj;
-      }, {} as { [k: string]: string })
-    )
-    // id and getRowCount are required, others are optional.
     .setProp({
       id: `${config.addonRef}-prefs-table`,
-      columns: addon.data.prefs?.columns,
+      // Do not use setLocale, as it modifies the Zotero.Intl.strings
+      // Set locales directly to columns
+      columns: addon.data.prefs?.columns.map((column) =>
+        Object.assign(column, {
+          label: getString(column.label) || column.label,
+        })
+      ),
       showHeader: true,
       multiSelect: true,
       staticColumns: true,